Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication in tests and benches #76

Open
DanieleDiBenedetto opened this issue Oct 15, 2020 · 0 comments
Open

Reduce code duplication in tests and benches #76

DanieleDiBenedetto opened this issue Oct 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@DanieleDiBenedetto
Copy link
Collaborator

DanieleDiBenedetto commented Oct 15, 2020 •
edited
Loading

Currently, for many crypto primitives/gadgets, we have as many tests/benches as concrete instantiations; however, the code for them is exactly the same.
We should write generic tests/benches, templatizing them with the curve, and enable them iff the corresponding compilation feature is enabled.
It is worth, maybe, as concrete instantiations of these tests, to keep only the Tweedle curve, that is the one we are most likely going to use in the future
@DanieleDiBenedetto DanieleDiBenedetto added the enhancement New feature or request label Oct 15, 2020
This was referenced Jan 19, 2021
Closed
Merged
@DanieleDiBenedetto DanieleDiBenedetto changed the title Reduce code duplication in tests Reduce code duplication in tests and benches Jan 19, 2021
DanieleDiBenedetto pushed a commit that referenced this issue Oct 21, 2021
@debris
no_std for algebra and r1cs-core (#76)
8a9343a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanieleDiBenedetto