Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher is broken on macOS #21

Open
mokou opened this issue Jul 21, 2017 · 4 comments
Open

Launcher is broken on macOS #21

mokou opened this issue Jul 21, 2017 · 4 comments
Assignees
Labels

Comments

@mokou
Copy link

mokou commented Jul 21, 2017

By default the filesystem on macOS is case-insensitive. Since the folder the launcher executable tries to write to is named Launcher it fails and crashes fairly early on.

A workaround that should work is renaming launcher to anything else, but when I do that it tries to download updates for whatever it's named instead of launcher.

When reporting a bug/issue:

  • Fantasy Crescendo Version: N/A
  • Operating System: macOS
  • Expected Behavior: A working launcher
  • Actual Behavior: The launcher crashes
  • Steps to reproduce the behavior:
  1. run ./launcher
  2. It crashes
@james7132
Copy link
Member

This is a design error, the fetched binary shouldn't depend on the local launcher binary's name.

@james7132 james7132 added the bug label Jul 21, 2017
@james7132 james7132 self-assigned this Jul 21, 2017
@james7132
Copy link
Member

Should be fixed as of 014a54b, does this still occur?

@mokou
Copy link
Author

mokou commented Jul 29, 2017

Works now, but if I keep the default name it downloads as (launcher.dms) it still crashes trying to download a non-existent file. Renaming it to launcher works though.

@james7132
Copy link
Member

We'll probably resolve this by creating a *.app instead of a standalone launcher. Apparently not using --onefile on PyInstaller will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants