New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10/3 V2 Review #4

Open

2 of 3 tasks

HsienW opened this issue Oct 3, 2019 · 0 comments

Owner

HsienW commented Oct 3, 2019 •

edited

Loading

code

webpack 配置需修改, bundle 出來有點奇怪
sessionStorage 簡化不需多包一層, 盡量應只有 token 即可
Header 應抽出為獨立一個

proposal

若該次call api 拿回來的 data 無其他要共用, 可簡化為 component 本身完成就好

HsienW mentioned this issue

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment