Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audio-params override to be disabled by default #199

Open
keianhzo opened this issue Feb 15, 2023 · 2 comments
Open

Make audio-params override to be disabled by default #199

keianhzo opened this issue Feb 15, 2023 · 2 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@keianhzo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When you add any audio element, the audio-params component is added too. By default this component override property is enabled. It will make more sense to keep override disabled by default, this is also how Spoke behaves by default

Describe the solution you'd like
Make override property disabled by default. we will need to migrate < 1.0.0 versions and set it to False. For beta versions we can't really know if it was set to True in purpose so probably easiest to not make assumptions and respect the incoming property value.

@Exairnous
Copy link
Contributor

I have a couple thoughts/observations on this issue.

  • I think defaulting the audio-params component to not override is fine, but I think the audio-target and audio-zone components should override that default when added and set it to override the audio because that is their main function.
  • As far as I can tell, add-on versions before the override was introduced always overrode the audio, so they should have the override set to True.
  • Since this was a new feature introduced near the end of the betas, it might be best to have the migration include versions less than or equal to 1.0.0 and just check whether that field is present, if it is then respect its value, if it isn't then set it to True.

@keianhzo
Copy link
Contributor Author

Yes, I think all that's reasonable.

@keianhzo keianhzo added this to the 1.2.0 milestone Mar 20, 2023
@keianhzo keianhzo added the good first issue Good for newcomers label Mar 20, 2023
@keianhzo keianhzo modified the milestones: 1.2.0, 1.2.1 Jul 19, 2023
@Exairnous Exairnous modified the milestones: 1.2.1, 1.3.0 Aug 7, 2023
@keianhzo keianhzo modified the milestones: 1.3.0, 1.4.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants