Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get config from environment variables instead of config files #3

Open
george-ayris opened this issue Nov 2, 2017 · 4 comments
Open

Comments

@george-ayris
Copy link
Collaborator

This is probably a more pythonic way of doing it

@george-ayris george-ayris changed the title Get secrets from environment variables instead of config files Get config from environment variables instead of config files Apr 11, 2018
@george-ayris
Copy link
Collaborator Author

First read from environment variables and fall back to config file if the environment variable aren't set?

@domgreen
Copy link
Collaborator

seems legit

@george-ayris
Copy link
Collaborator Author

How much sense does this make for collections (i.e. the PROJECTS and PACKAGE_SOURCES) and dictionaries (i.e. `OCTOPUS_HEADERS) to be stored in environment variables? Because you're probably going to have to serialise them to JSON anyway to store them as a string, which means they'll be a pain to set manually.

A single secret like the x-octopus-apikey seems to make more sense to me?

@penderi
Copy link

penderi commented Apr 11, 2018

I wonder if either is valid. There's arguments both ways over what takes precedence. Is there prior art ??
Perhaps, env variables only for things than can change between environments?
I also wonder in an Octopus world why use env variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants