Skip to content

Commit 1fd2102

Browse files
fix: FIT-831: Member dropdown in Member Performance Dashboard not working (#8686)
Co-authored-by: yyassi-heartex <[email protected]>
1 parent 354214c commit 1fd2102

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

web/libs/ui/src/lib/select/select.tsx

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ export const Select = forwardRef(
8787
pageSize = VARIABLE_LIST_PAGE_SIZE,
8888
page = 1,
8989
itemCount,
90+
onClose,
91+
onOpen,
9092
...props
9193
}: SelectProps<T, A>,
9294
_ref: ForwardedRef<HTMLSelectElement>,
@@ -143,7 +145,10 @@ export const Select = forwardRef(
143145
valueRef.current = val;
144146
setValue(val);
145147
}
146-
!multiple && setIsOpen(false);
148+
if (!multiple) {
149+
setIsOpen(false);
150+
onClose?.();
151+
}
147152
props?.onChange?.(valueRef.current);
148153
setTimeout(() => {
149154
const changeEvent = new Event("change", {
@@ -310,7 +315,13 @@ export const Select = forwardRef(
310315
}, [_options, multiple, isSelected, _onChange]);
311316

312317
const combobox = (
313-
<Popover open={isOpen} onOpenChange={setIsOpen}>
318+
<Popover
319+
open={isOpen}
320+
onOpenChange={(_isOpen) => {
321+
setIsOpen(_isOpen);
322+
_isOpen ? onOpen?.() : onClose?.();
323+
}}
324+
>
314325
<PopoverTrigger asChild={true} disabled={disabled}>
315326
<button
316327
variant="outline"

web/libs/ui/src/lib/select/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ export type SelectProps<T, A extends SelectOption<T>[]> = {
8383
pageSize?: number;
8484
page?: number;
8585
itemCount?: number;
86+
onClose?: () => void;
87+
onOpen?: () => void;
8688
} & SelectVirtualizedProps &
8789
Omit<React.SelectHTMLAttributes<HTMLSelectElement>, "value" | "placeholder">;
8890

0 commit comments

Comments
 (0)