Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot discovery fails to use correct interface in some networks #44

Open
andreas-kraus opened this issue Sep 16, 2020 · 1 comment
Open
Assignees
Labels
bug Something isn't working serverland network, structure, dataflow, osc, robot handling

Comments

@andreas-kraus
Copy link
Collaborator

The automatic robot discovery only works correctly, if the ipv4 network is first in the list of networks.
The code that should have prevented this has some issues. I was able to fix it for my network setup, but I'm not sure if this will fix it for everyone.

In the function Serverland/controller/controller.js -> searchRobots(), the "alias" variable is not being incremented when skipping ipv6 and local networks, it is only ever increased at the end of the function and never get bigger that 1. This causes the "searchalias" to be set incorrectly, which in turn causes the wrong network to be selected for searching.
I think it's possibly fixable by incrementing the "alias" whenever a network is skipped.

@andreas-kraus andreas-kraus added serverland network, structure, dataflow, osc, robot handling bug Something isn't working labels Sep 16, 2020
@HybridThings
Copy link
Contributor

Looks good now. But let's keep issue open and double check after first release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working serverland network, structure, dataflow, osc, robot handling
Projects
None yet
Development

No branches or pull requests

3 participants