-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add push notifications service to web app #63
Comments
I would like to take this. @bhansa @ananyo2012 Can you help me with what type notifications will we be adding? from #34 I understood there are these notifications to be added:
Also, I can create a static document database for storing our data in firebase. We can use the |
Hi @ashwani99, thanks for picking up this issue. As of now we have decided to go with the above types of notifications which you mentioned. About the idea of creating static document, I am not much aware of it. |
@ashwani99 Also it will be helpful if you can link a blog post or some documentation on the firebase setup you are planning to do and how we can manage access to the firebase app. |
@bhansa By static document, I meant exact copy of the data files (we need to convert from yaml to json) into the firebase database.
We need a firebase DB and we have to configure the firebase to send messages when a change in DB occurs and notify whenever message is received. So, requests to firebase is necessary. @ananyo2012 I am thinking of a solution somewhat like shown in this video except that it is done in Angular. As the data needs to be in firebase, we will be duplicating the data in the data files as well as in the firebase DB but as @bhansa mentioned, this will be overhead. Please add your thoughts on this. As this is a static site, I don't think adding push notifications is necessary. Can we use a twitter widget showing tweets from official HydPy account for the notifications? |
@ashwani99 The purpose of adding push notifications is to make the PWA little bit more interactive. It's an addition to the present app. To update the Data in firebase we can write a service that will update the data in firebase whenever an update is made in the corresponding data file in the github repo. But this is kind of a further plan and doesn't come under this issue. Just getting the basic setup working is the goal of the current issue. |
@ashwani99 any progress on this? |
@ananyo2012 Can I try this? |
@Aditya-369 Please go ahead and let us know the necessary setup you need. |
Hey @ananyo2012 so I started working on this today. Seems that #133 does well. Is there some specific functionality to look over? |
Add push service once the service worker is implemented.
Reference: https://developers.google.com/web/ilt/pwa/introduction-to-push-notifications
https://firebase.google.com/docs/cloud-messaging/js/client
Few details under #34
The text was updated successfully, but these errors were encountered: