Improve integer weight draw and flaky error message #3949
Merged
+32
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
force-pushed
the
integer-weights-better
branch
2 times, most recently
from
bd9b45e to
e3c9d82
Compare
Zac-HD
approved these changes
Apr 8, 2024
tybug
force-pushed
the
integer-weights-better
branch
from
5bd591c to
f5bdd22
Compare
tybug
force-pushed
the
integer-weights-better
branch
from
f5bdd22 to
4b88c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3921 (comment) by always drawing the integer value from the full range.
Also closes #3940 by improving the error message.
(worked on irl with @Zac-HD 😄)