Migrate explain phase to the typed choice sequence
#4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, not sure if this failure is related yet FAILED whole_repo_tests/test_mypy.py::test_stateful_bundle_generic_type - AssertionError:
assert 0 == 1
+ where 0 = len([])
+ where [] = <built-in method splitlines of str object at 0x7f80b1108030>()
+ where <built-in method splitlines of str object at 0x7f80b1108030> = ''.splitlines |
4 tasks
|
I think I've seen that flake before; probably we should just add a few retries in case the command returns empty string? I also noticed that it looks like a subsequent mypy upgrade has this test passing, so we can remove the xfail 🙂 |
Zac-HD
approved these changes
Nov 9, 2024
Comment on lines
+1531
to
+1540
| # a draw_bits call which straddles the end of our prefix has a slightly | ||
| # different code branch. | ||
| def test(data): | ||
| # float consumes draw_bits(64) | ||
| data.draw_float() | ||
|
|
||
| with deterministic_PRNG(): | ||
| runner = ConjectureRunner(test, settings=TEST_SETTINGS) | ||
| d = runner.cached_test_function(bytes(10), extend=100) | ||
| assert d.status == Status.VALID |
There was a problem hiding this comment.
drawing one float uses <10 bytes, I think?
There was a problem hiding this comment.
It's more - a bunch for the sampler, 1 for the sign, and 8 for the value. I only added this test because the branch mentioned in the comments was uncovered, so I'm pretty confident this test does indeed execute that branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3864. Take two of #4160 due to git weirdness.