New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing for CAN/CAN-FD frames #60

Open

pd0wm opened this issue May 11, 2024 · 0 comments

Labels

Contributor

pd0wm commented May 11, 2024 •

edited

Loading

Try to make impossible states not representable, but hopefully not by making the UX worse. E.g.

Remote frames cannot contain any data. Separate type?
Remote frames cannot be CAN-FD.
Split out CAN/CAN-FD data frames into separate types? Or keep as a flag? CAN-FD has special flags (e.g. BRS).
Split out Error frame as separate type?
Investigate use of [u8; 64] instead of Vec for CAN data storage

pd0wm added the enhancement label

pd0wm closed this as completed

pd0wm reopened this

pd0wm changed the title ~~Create separate types for CAN/CAN-FD~~ Improve typing for CAN/CAN-FD

pd0wm changed the title ~~Improve typing for CAN/CAN-FD~~ Improve typing for CAN/CAN-FD frames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment