Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS - pulmonary - lacking domain renaming rules #168

Open
andkov opened this issue Jan 27, 2017 · 3 comments
Open

NAS - pulmonary - lacking domain renaming rules #168

andkov opened this issue Jan 27, 2017 · 3 comments
Assignees

Comments

@andkov
Copy link
Member

andkov commented Jan 27, 2017

@ampiccinin , i have added the script to rename the domain in pulmonary-cog track according to the schema you've sent over email. Please see the updated correlation reports for pulmonary at https://github.com/IALSA/IALSA-2015-Portland/tree/master/projects/pulmonary-cognitive (full and focus)

However, NAS does not have a female subgroup, so due to the fact that female subgroup was chosen as the starting point for your renaming schema, you'll notice that male portion has NA in domain field for NAS study.

Using the files in ./reports/correlation-3/table-data, please edit the file ,/reports/correaltion-3/rename-domains-pulmonary.csv to add how you would like the domains in NAS to be re-categoried. You can either edit the file in Excel and then push (makes sure you preserve csv format) or feel free to download it, edit and send it over email. either if fine.

@ampiccinin
Copy link
Member

@andkov - thanks - good start - I'll fix male/NAS.

Issue: I think we need to break memory into two parts because otherwise the immediate and delayed measures (etc.) get all jumbled up since it prioritizes sorting by study. And because it is a rather long list. Do I need to type this, or can you tell from the email I sent Sean regarding "Immediate memory" vs "Delayed and Working memory"

@ampiccinin
Copy link
Member

@andkov ..."immediate memory" doesn't work since then recognition is left out, so I just left it as "memory".

Could change it to "immediate and recognition memory", or could simply drop the recognition measures (there are only two and they are quite different from one another). Oddly, I did not make notes on these from the seed reports. Not sure how I missed them.

@andkov
Copy link
Member Author

andkov commented Jan 27, 2017

@ampiccinin , I see an email on Wed 2017-01-25 5:23 PM where you mention this, but don't see the listing on how you want to divide them. Would you mind replacing these labels in ,/reports/correaltion-3/rename-domains-pulmonary.csv so that I avoid guessing? Just replace "memory" by whatever labels you see appropriate.

Alternatively, please forward to me the email where you do list them, i wonder if I just missed it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants