Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: please add support for zita-a2j and zita-j2a #1

Open
shimpe opened this issue Sep 3, 2018 · 3 comments
Open

feature request: please add support for zita-a2j and zita-j2a #1

shimpe opened this issue Sep 3, 2018 · 3 comments

Comments

@shimpe
Copy link

shimpe commented Sep 3, 2018

these are "improved" alsa_in and alsa_out replacements (better performance, better quality resampling)

@IARI
Copy link
Owner

IARI commented Sep 16, 2018

The crucial parts of the code are

    @property
    def cmdName(self):
        # TODO: support alternative bridges, i.e. zita-ajbridge
        return "alsa_{}".format("in" if self._in else "out")

in interface.py line 32
and

CMD_PAT = '{cmd} -j "{name}" -d {hw}'

in interface.py line 92

apparently at some point i had already planned for this, but since then I didn't do any Jack development
Currently I have no system running Jack I'm working on, so I can't test anything.
But probably you can just replace "alsa_{}".format("in" if self._in else "out") with
"zita-{}".format("a2j" if self._in else "j2a") (or maybe a2j needs to be swapped with j2a)
Let me know, if that worked for you.

@shimpe
Copy link
Author

shimpe commented Dec 25, 2018

Just replacing the way you suggested works perfectly! Thanks.

@darinrogers
Copy link

@IARI I could submit a PR, or fork this repository with the changes to use zita-ajbridge instead. I just started using it with the patch you proposed and should know pretty quickly if it's stable. It immediately seems better than alsa_in/alsa_out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants