Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling of links (within a paragraph), including hover-over / active state #42

Open
stevieflow opened this issue Jan 23, 2025 · 2 comments

Comments

@stevieflow
Copy link

As we implement the design system more, the lack of any active / hover-over design (if I perceive this correctly: https://iati.github.io/design-system/?path=/story/core-typography--links) is apparent

This, coupled with (imho) the fact that links are very faint (is that the font, or my eyes?) on a white bg (whether that be a card or the page) seems to render links in a way that I dont think is optimal

I understand that @notshi has also experienced and voiced this via working on IATI/D-Portal#660

Please can we take a look at this @robredpath @tillywoodfield ? cc/ @IsabelBirds @Bjwebb @chrisarridge

@chrisarridge
Copy link
Contributor

I'm in agreement about the link rendering. I think it's a compound issue of mainly colour and weight.

The colour contrast is fairly low (and putting it on F6F6F6 will make it worse). Note that the same font and colour is used for breadcrumbs and is fairly legible, but it's a heavier weight.

We're currently using a "light" weight for our body rendering and so I think increasing to normal would be good.

Font-weight 300 ("light"):
Image

Font-weight 400 ("normal"):
Image

So I think a small change to normal font weight and maybe exploring some alternative colours would help.

@stevieflow
Copy link
Author

Thanks @chrisarridge - that seems practical and reasonable

re: The colour contrast is fairly low (and putting it on F6F6F6 will make it worse).

It would be useful if we consider this too, with #37 (although I understand this bg color would not be for body text...)

Aside from the weight , should we expect that such links have a state when visited, unvisited, or active? That's quite standard stuff, designed to help people, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants