Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart inconsistent naming results in Services not binding to Pods #96

Open
DazWilkin opened this issue Jun 6, 2018 · 0 comments
Open

Comments

@DazWilkin
Copy link

Helm Chart inconsistently uses ibm-blockchain-network.name and ibm-blockchain-network.fullname

E.g.
CA Service selects on name == -network.name and app == -network.name
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca-service.yaml#L15

But CA Deployment name == -network.fullname (!?) and app == -network.name
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca.yaml#L15

This is true for all of the Deployment-Service pairs and so none of the Services binds to Pods

Recommend:
-- Use -network.name or -network.fullname consistently
-- -network.name [my preference] is simpler but could result in collisions with multiple deployments !?
-- '-network.fullname` is more long-winded but should avoid collisions
-- But are collisions likely? Wouldn't it be better to partition by namespaces anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant