Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm_sm_private_certificate unsupported argument: rotation.rotate_keys #4976

Closed
davesteinberg opened this issue Dec 8, 2023 · 2 comments
Closed
Assignees
Labels
documentation service/Secrets Manager Issues related to Secrets Manager

Comments

@davesteinberg
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s) or Datasource(s)

  • ibm_sm_private_certificate

Description

I tried using rotation.rotate_keys as documented here. Here's my resource:

resource "ibm_sm_private_certificate" "vpn_server" {
  instance_id          = ibm_resource_instance.sm.guid
  region               = var.region
  name                 = "${var.prefix}-management-vpn-server-cert"
  certificate_template = resource.ibm_sm_private_certificate_configuration_template.vpn_server.name
  secret_group_id      = ibm_sm_secret_group.common.secret_group_id
  common_name          = "vpn-server.vpn.ibm.com"
  ttl                  = "${365 * 3}d"
  rotation {
    auto_rotate = true
    rotate_keys = true
    interval    = 365 * 3 - 30
    unit        = "day"
  }
}

When I try to run terraform apply with the latest version of the provider (1.60.0), it fails:

$ terraform apply        
╷
│ Error: Unsupported argument
│ 
│   on vpc.tf line 199, in resource "ibm_sm_private_certificate" "vpn_server":
│  199:     rotate_keys = true
│ 
│ An argument named "rotate_keys" is not expected here.

If I simply remove rotate_keys from the rotation, it works.

If this argument isn't supported (yet?), it should be removed from the documentation.

@github-actions github-actions bot added the service/Secrets Manager Issues related to Secrets Manager label Dec 8, 2023
@ArikShifer
Copy link

Argument is only supported when using an ibm_sm_public_certificate resource. It will be removed from ibm_sm_private_certificate doc.

@IdanAdar
Copy link
Collaborator

IdanAdar commented Jan 3, 2024

Fixed in 1.61.

@IdanAdar IdanAdar closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation service/Secrets Manager Issues related to Secrets Manager
Projects
None yet
Development

No branches or pull requests

4 participants