-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyError: 'graphite' raised when graphite key is not in config.yaml #72
Comments
This shouldn't be required - will look at how this can be handled better. As yet I'm also unaware of anyone using trawler with graphite |
rickymoorhouse
added a commit
that referenced
this issue
Aug 30, 2023
rickymoorhouse
added a commit
that referenced
this issue
Aug 30, 2023
rickymoorhouse
added a commit
that referenced
this issue
Dec 5, 2023
fix for #72 Signed-off-by: Ricky Moorhouse <[email protected]>
rickymoorhouse
added a commit
that referenced
this issue
Dec 5, 2023
fix for #72 Signed-off-by: Ricky Moorhouse <[email protected]>
I'm still encounter the same error as of latest git clone version. Seem like I still need to put "graphite" key into yaml otherwise I will got the error |
rickymoorhouse
added a commit
that referenced
this issue
Apr 11, 2024
Ah looks like I missed a place in the fix - have an additional fix coming |
rickymoorhouse
added a commit
that referenced
this issue
Apr 11, 2024
#72 Signed-off-by: Ricky Moorhouse <[email protected]>
rickymoorhouse
added a commit
that referenced
this issue
Apr 11, 2024
* fix: only try and get token if password set Signed-off-by: Ricky Moorhouse <[email protected]> * fix: additional graphite reference #72 Signed-off-by: Ricky Moorhouse <[email protected]> --------- Signed-off-by: Ricky Moorhouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running the project with a config.yaml file that doesn't include the graphite key, the following error is raised:
This seems to indicate that the graphite key is expected in the config.yaml file, although it's not included in example configurations or documented.
Steps to Reproduce:
SECRETS=test-assets coverage run --source . -m py.test
python3 trawler.py --config deployment/config.yaml
Expected Behavior:
The application should either run without requiring the graphite key or should provide a more descriptive error message if the key is required.
Suggested Solution:
Document the graphite Key: Update the example config.yaml file and documentation to include the graphite key. For example:
The text was updated successfully, but these errors were encountered: