Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn audit --json out of memory handling #190

Open
geoffreyp7 opened this issue Jul 2, 2021 · 1 comment
Open

yarn audit --json out of memory handling #190

geoffreyp7 opened this issue Jul 2, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@geoffreyp7
Copy link

Hi, first of all thanks for providing and maintaining this package.

I've noticed an interesting issue relating to yarnpkg/yarn#7404

When the yarn audit runs out of memory as described in the yarn issue this results in audit-ci generating an audit pass.

It's hard to say what the expected behaviour is here.. I know the root issue is not the fault of this package, but a pass in this case could mask this issue for some time in a CI environment, missing vulnerabilites.

I've verified this by profiling memory usage, the instant it hits the max heap size an audit pass is generated.

@quinnturner quinnturner added the bug Something isn't working label Jul 6, 2021
@quinnturner
Copy link
Member

Thank you for the bug report! Having audit-ci swallow and pass an audit on an out of memory error is definitely not the right behaviour. Should probably just bubble up the error and let the process exit with a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants