Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar-icon at top position #74

Open
jhgoebbert opened this issue Jun 11, 2022 · 1 comment
Open

sidebar-icon at top position #74

jhgoebbert opened this issue Jun 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jhgoebbert
Copy link
Contributor

Describe the bug
The sidebar icon of jupyterlab-s3-browser is located at the first top position in the left sidebar in our setup.
This is IMHO reserved for JupyterLab's filebrowser. So I would consider this as a bug 🤔

image

I have seen screenshots of jupyterlab-s3-browser where this was not the case.
Perhaps this bug only appears with a certain JupyterLab version ... we are using 3.4.3

Desktop:

  • OS: Windows 10
  • Browser Firefox 101
  • Version of jupyterlab-s3-browser extension 0.12.0
@jhgoebbert jhgoebbert added the bug Something isn't working label Jun 11, 2022
@jhgoebbert
Copy link
Contributor Author

You set rank to 100 here:
https://github.com/IBM/jupyterlab-s3-browser/blob/master/src/index.ts#L71

If you follow the recommendations for rank from the documentation here
https://jupyterlab.readthedocs.io/en/stable/extension/extension_points.html#left-right-areas

    0-500: reserved for first-party JupyterLab extensions.
    501-899: reserved for third-party extensions.
    900: The default rank if none is specified.
    1000: The JupyterLab extension manager.

you might want to change that 501 at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants