Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containment based queries optimized #537

Merged
merged 20 commits into from
Jul 16, 2023

Conversation

tanyaveksler
Copy link
Member

No description provided.

Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Returning 'passed' code for skipped queries.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
…e times for the same rule, for example when a rule appears twice in a config).

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Commented out containment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the test fails.

Signed-off-by: Tanya <[email protected]>
Commented out twoWayContainment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the tests fail.

Signed-off-by: Tanya <[email protected]>
@tanyaveksler tanyaveksler self-assigned this Jun 25, 2023
@tanyaveksler tanyaveksler requested a review from adisos June 25, 2023 18:39
nca/Resources/NetworkPolicy.py Show resolved Hide resolved
nca/SchemeRunner.py Show resolved Hide resolved
@tanyaveksler tanyaveksler merged commit 59f6126 into master Jul 16, 2023
16 checks passed
@tanyaveksler tanyaveksler deleted the containment-based-queries-optmized branch July 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants