Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Exception thrown and not caught #495

Open
abdonrd opened this issue Oct 14, 2020 · 10 comments · May be fixed by IBM/pwa-lit-template#179
Open

Error: Exception thrown and not caught #495

abdonrd opened this issue Oct 14, 2020 · 10 comments · May be fixed by IBM/pwa-lit-template#179
Labels

Comments

@abdonrd
Copy link
Contributor

abdonrd commented Oct 14, 2020

I just found a problem with the Vaadin Router; it doesn’t work in legacy browsers.
The error is this: Exception thrown and not caught.

Screenshot 2020-10-13 at 17 20 39 (1)

Seems like it happens when the __addAppearingContent() call the this.__ensureOutlet() here:
https://github.com/vaadin/vaadin-router/blob/c81fea90e19859ab28bebac72843bf0f68c6996b/src/router.js#L786

I’m using the @open-wc/building-rollup setup.

Repository: https://github.com/IBM/pwa-lit-template
Live demo: https://pwa-lit-template.mybluemix.net

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 14, 2020

If we go back to this PR from @web-padawan, it works again!

IBM/pwa-lit-template#64

In this PR we defer setting outlet until app-index is rendered.

@web-padawan
Copy link
Member

Thanks for the issue. Do I understand correctly that my PR introduced a regression which only reproduces in old Edge?

I would appreciate a reduced test case that would help us to pinpoint the actual bug.

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 14, 2020

Exactly!

If we go back with this changes (revert-router branch), it works again:

Screenshot 2020-10-14 at 10 48 03

@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 14, 2020

Logging the __ensureOutlet method.

console.log('__ensureOutlet', outlet);

Chrome:

Screenshot 2020-10-14 at 11 06 21

Edge:

Screenshot 2020-10-14 at 11 06 26

@abdonrd
Copy link
Contributor Author

abdonrd commented Nov 25, 2020

Any news about this from the Vaadin team?

@haijian-vaadin
Copy link
Contributor

Hi @abdonrd, do I understand correctly that this error only happens in legacy browsers? If this is the case, unfortunately, we decided to align the browser support with Vaadin, which means that we won't fix if the bug is only on old Edge. But if it also happens on the latest Edge, then we definitely should fix it.

@abdonrd
Copy link
Contributor Author

abdonrd commented Nov 26, 2020

We found out because Rendertron stopped working for us.

And we have been able to reproduce it in browsers such as:

photo_2020-11-26 12 02 18

@abdonrd
Copy link
Contributor Author

abdonrd commented Feb 2, 2021

Since I see movement in the project... (thanks! 🎉 )

@Haprog @platosha @vlukashov @haijian-vaadin could you help us with this?
We have a proposal here: IBM/pwa-lit-template#179

Thanks in advance!

@Haprog
Copy link
Contributor

Haprog commented Feb 2, 2021

Did I understand right that this affects only old Edge (non-Chromium)? And maybe IE11?
And there is a workaround that works?

I think it's unlikely that we would fix this since we're now targeting support for modern browsers only. See https://github.com/vaadin/vaadin-router/pull/548/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@abdonrd
Copy link
Contributor Author

abdonrd commented Feb 2, 2021

@Haprog we found out because Rendertron (puppeteer & chrome-launcher) stopped working for us since IBM/pwa-lit-template#64.

And we have been able to reproduce it in browsers such Edge, but I'm not sure.

A workaround that seems to work is IBM/pwa-lit-template#179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants