Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Label descriptions within details elements flagging rule #1557

Closed
zJag opened this issue Jul 18, 2023 · 4 comments · Fixed by #1759
Closed

[BUG]: Label descriptions within details elements flagging rule #1557

zJag opened this issue Jul 18, 2023 · 4 comments · Fixed by #1759
Assignees
@shunguoy @ErickRenteria
Labels
engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation priority-2 (med) Ready for QA user-reported Issues identified outside of the core team

Comments

@zJag
Copy link

zJag commented Jul 18, 2023

Project

a11y checker extension

Browser

Chrome

Operating system

MacOS

Description

Description

When using a <details> element that contains a label with a child element in it's content, the label description rule is flagged when the details is closed. When opened, the rule is not flagged.

Expectation

If the label is accessible when the details element is expanded, it should be accessible when the element is collapsed.

Steps to reproduce

  • Create a details element with whatever summary
  • In content add a label with for referencing an input element
  • Within label content add <p>label</p>
  • Run test once with the details section collapsed
  • Run test again with the details section expanded

CodeSandbox: https://codesandbox.io/s/eloquent-hofstadter-mm8r9n
@shunguoy
Copy link
Contributor

triage: when it's closed, it shouldn't require a label because the label and input are not visible.

@shunguoy shunguoy added engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation user-reported Issues identified outside of the core team priority-2 (med) labels Jul 24, 2023
@shunguoy
Copy link
Contributor

see also #1008

shunguoy added a commit that referenced this issue Nov 27, 2023
@shunguoy
initial rule update and test cases #1557
44b4ece
@shunguoy shunguoy mentioned this issue Nov 28, 2023
Merged
5 tasks
shunguoy added a commit that referenced this issue Nov 28, 2023
@shunguoy
update the rule on label text calculation #1557
98df636
@shunguoy
Copy link
Contributor

#1759 for review by Tom

@philljenkins philljenkins linked a pull request Dec 11, 2023 that will close this issue
fix(engine): fix issues related to element text calculation #1759
Merged
5 tasks
@ErickRenteria
Copy link
Contributor

Validated

evannaderi pushed a commit to evannaderi/udoit-equal-access that referenced this issue Jan 31, 2025
@shunguoy
initial rule update and test cases IBMa#1557
60db664
evannaderi pushed a commit to evannaderi/udoit-equal-access that referenced this issue Jan 31, 2025
@shunguoy
update the rule on label text calculation IBMa#1557
b22c953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

@ErickRenteria ErickRenteria

Labels
engine Issues in the accessibility-checker-engine component false-positive Rules incorrectly reporting a violation priority-2 (med) Ready for QA user-reported Issues identified outside of the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(engine): fix issues related to element text calculation IBMa/equal-access
4 participants
@philljenkins @shunguoy @zJag @ErickRenteria