Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria_content_in_landmark flags skip links as content outside landmark #2134

Closed
1 of 8 tasks
stjordan opened this issue Dec 16, 2024 · 2 comments
Closed
1 of 8 tasks
Assignees
Labels
engine Issues in the accessibility-checker-engine component T64 user-reported Issues identified outside of the core team

Comments

@stjordan
Copy link

stjordan commented Dec 16, 2024

Describe the bug
The aria_content_in_landmark rule flags skip links as content outside a landmark. Skip links are not content and adding a needless landmark worsens the screen reader experience.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://designsystem.digital.gov/ or many other websites, such as whitehouse.gov
  2. Run the Accessibility Assessment from Chrome Dev Tools
  3. Observe that /document[1] /link[1] is flagged for being outside a landmark

Expected behavior
/document[1] /link[1] is not flagged for being outside a landmark. Perhaps the heuristic is to exclude the link from this rule if it is the first link in the DOM and its target is the main landmark.

Desktop (please complete the following information):

  • OS: macOS 14.6
  • Browser: chrome
  • Version: 131.0.6778.139

Definition of Done

  • Design artifacts reviewed
  • Work item implemented
  • Automated test case created (when applicable)
  • Unit test completed
  • Run Checker (when applicable)
  • Manual and Screen Reader Testing (when applicable)
  • Video recording of user experience walkthrough (if impact to UX)
  • PR created
@MHoov MHoov added user-reported Issues identified outside of the core team engine Issues in the accessibility-checker-engine component labels Dec 16, 2024
@shunguoy shunguoy added the T64 label Jan 6, 2025
@tombrunet
Copy link
Member

tombrunet commented Jan 6, 2025

@stjordan This rule is not included in the WCAG rulesets - it is only in the IBM Accessibility ruleset. By convention, the skip link would be the first link in the banner, and therefore should be within a landmark. The rule is working as designed.

@philljenkins
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component T64 user-reported Issues identified outside of the core team
Projects
None yet
Development

No branches or pull requests

5 participants