Merge pull request #12 from SylvainMartel/ansible_json_output

vpcfix + changed outputs
ICCS-ISAC · May 23, 2024 · 02acd8b · 02acd8b
2 parents 9dc8a22 + 56b7168
commit 02acd8b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 29 deletions.
diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml
diff --git a/networking.tf b/networking.tf
@@ -2,7 +2,7 @@
 resource "aws_eip" "public_client_ip" {
   count = var.use_elastic_ips ? 1 : 0
 
-  vpc                       = true
+  domain                    = "vpc"
   network_interface         = aws_network_interface.client_nic[count.index].id
   associate_with_private_ip = aws_network_interface.client_nic[count.index].private_ip
 
@@ -19,7 +19,7 @@ resource "aws_eip" "public_client_ip" {
 resource "aws_eip" "public_node_ip" {
   count = var.use_elastic_ips ? 1 : 0
 
-  vpc                       = true
+  domain                    = "vpc"
   network_interface         = aws_network_interface.node_nic.id
   associate_with_private_ip = aws_network_interface.node_nic.private_ip
 

diff --git a/outputs.tf b/outputs.tf
@@ -6,6 +6,11 @@ output "node_info" {
     aws_ebs_volume.data_volume.id,
     # node_seed
     # Remove special characters and crop to into a 32 character seed.
-    substr(replace(replace(random_id.node_seed.b64_url, "_", ""), "-", ""), 0, 32)
+    substr(replace(replace(random_id.node_seed.b64_url, "_", ""), "-", ""), 0, 32),
+    # The node's public Client IP.   Used later on for automatic genesis file generation
+    aws_eip.public_client_ip,
+    # The node's public Node IP.  Used later on for automatic genesis file generation.  
+    # Should be the same as the first output, but we are putting this here anyay for clarity.
+    aws_eip.public_node_ip
   ]
 }