Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookahead in GEMM is not good #119

Open
QingleiCao opened this issue Jul 21, 2024 · 6 comments
Open

Lookahead in GEMM is not good #119

QingleiCao opened this issue Jul 21, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@QingleiCao
Copy link

The default lookahead in GEMM is 2, which is too small if running on multiple nodes, especially for large scaling. It should be related to the process grid.

@QingleiCao QingleiCao added the bug Something isn't working label Jul 21, 2024
@bosilca
Copy link
Contributor

bosilca commented Jul 22, 2024

So what is a good lookahead ? If we had a table of good/better lookahead per problem-size we could try to fit it into a formula that covers most cases.

@QingleiCao
Copy link
Author

I implemented a SUMMA SYRK, where A (input) in INT8 and C (output) in FP32. It seems lookahead = P is not bad (a formula with some theory support? :)). This is what I tested on 256 Summit nodes.

image

@QingleiCao
Copy link
Author

(2 processes per node)

@QingleiCao
Copy link
Author

image

@bosilca
Copy link
Contributor

bosilca commented Jul 22, 2024

Looks good, let's make it P then. I guess the only thing one need to do is replace the LOOK_AHEAD [ type = int ] line with LOOK_AHEAD [ type = int default = tP]

@QingleiCao
Copy link
Author

Looks good, let's make it P then. I guess the only thing one need to do is replace the LOOK_AHEAD [ type = int ] line with LOOK_AHEAD [ type = int default = tP]

Yes. Do I need to make a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants