Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PETSc scaling and unscaling #1410

Open
dallan-keylogic opened this issue May 13, 2024 · 0 comments
Open

Fix PETSc scaling and unscaling #1410

dallan-keylogic opened this issue May 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working core Issues dealing with core modeling components PETSc Priority:Normal Normal Priority Issue or PR scaling_v2

Comments

@dallan-keylogic
Copy link
Contributor

Presently, PETSc ignores the active attribute of scaling suffixes and scales/unscales the corresponding blocks anyway. It needs to be fixed to take this attribute into account and probably modified to look for scaling suffixes in more places than it looks now (either the component's parent block or the overall model) using Pyomo's suffix locator:

from pyomo.core.base.suffix import SuffixFinder

suffix_finder = SuffixFinder('scaling_factor', 1.0)
suffix_finder.find(component)
@dallan-keylogic dallan-keylogic self-assigned this May 13, 2024
@dallan-keylogic dallan-keylogic added bug Something isn't working Priority:Normal Normal Priority Issue or PR core Issues dealing with core modeling components PETSc scaling_v2 labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issues dealing with core modeling components PETSc Priority:Normal Normal Priority Issue or PR scaling_v2
Projects
None yet
Development

No branches or pull requests

1 participant