Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on Evaluation Metrics #28

Open
VicZlq opened this issue Nov 10, 2023 · 5 comments
Open

Questions on Evaluation Metrics #28

VicZlq opened this issue Nov 10, 2023 · 5 comments

Comments

@VicZlq
Copy link

VicZlq commented Nov 10, 2023

Thank you very much for your work, we recently tried to add your work for comparison but had some problems with the assessment indicators.

Do you have a reference code for Pose Cosine Similarity-based AP (CAP) and People Count Error (PCE) ? We would like to ensure consistency of values. Thank you very much!:)

@VicZlq
Copy link
Author

VicZlq commented Nov 10, 2023

Thank you very much for your work, we recently tried to add your work for comparison but had some problems with the assessment indicators.

Do you have a reference code for Pose Cosine Similarity-based AP (CAP) and People Count Error (PCE) ? We would like to ensure consistency of values. Thank you very much!:)

@VicZlq VicZlq closed this as completed Nov 10, 2023
@juxuan27
Copy link
Contributor

Hi, @VicZlq . It is provided here. Thank you for your focus.

@VicZlq VicZlq reopened this Nov 17, 2023
@VicZlq
Copy link
Author

VicZlq commented Nov 17, 2023

Thank you very much for your reply!
I'm having some problems with the review.
I loaded the humansd-v1.ckpt weights and got a bug when running pose2img_metrics.py:
File "/storage/zhaoliuqing/code/HumanSD/ldm/util.py", line 83, in instantiate_from_config
if not "target" in config.
TypeError: argument of type 'NoneType' is not iterable

I've debugged and it seems that the supplied file does not have a “.model” target in config, have you encountered this problem?

@VicZlq
Copy link
Author

VicZlq commented Nov 17, 2023

Thank you very much for your reply! I'm having some problems with the review. I loaded the humansd-v1.ckpt weights and got a bug when running pose2img_metrics.py: File "/storage/zhaoliuqing/code/HumanSD/ldm/util.py", line 83, in instantiate_from_config if not "target" in config. TypeError: argument of type 'NoneType' is not iterable

I've debugged and it seems that the supplied file does not have a “.model” target in config, have you encountered this problem?

I checked the metrics.yaml code and it seems to be missing model and data settings in there. I copied the model configuration from inference and the problem seems to be solved :)

Do you have the metrics.yaml configuration file that contains the model and data information for inference at that time?

@juxuan27
Copy link
Contributor

Sorry for the late reply. Copying the model configuration from inference is the right way to solve the problem. We will update the yaml file in the revised version. Thank you for pointing out the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants