Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Consistency across button interactions #2232

Open
jfmcquade opened this issue Mar 12, 2024 · 2 comments · May be fixed by #2351
Open

[FEATURE] Consistency across button interactions #2232

jfmcquade opened this issue Mar 12, 2024 · 2 comments · May be fixed by #2351
Labels
feature Work on app features/modules good first issue

Comments

@jfmcquade
Copy link
Collaborator

What?
Currently, button-like components can exhibit one of three different behaviours when clicked on:

  1. An animated ripple effect, e.g. most variations of the button component
ripple.mov
  1. A static colour change, e.g. button with variant: card-portrait
card.portrait.mov
  1. No interaction, e.g. tile components
tile.mov

These interactions should be standardised across all button-like components, likely favouring the ripple effect.

Why?
Ensuring that similar components feel and behave similarly improves the UX

How?
We should be able to add the ion-ripple-effect to all relevant clickable components
@jfmcquade jfmcquade added feature Work on app features/modules good first issue labels Mar 12, 2024
@kwAsant
Copy link
Collaborator

kwAsant commented Jul 8, 2024

Card-portrait cannot have ripple effect. Seems to be the same with the tile too.

@jfmcquade
Copy link
Collaborator Author

jfmcquade commented Jul 8, 2024 •
edited
Loading

Card-portrait cannot have ripple effect. Seems to be the same with the tile too.

I got a version working on the card-portrait button. Demo:

button.card.ripple.mov

Here are the code changes to src/app/shared/components/template/components/button/button.component.html:
Screenshot 2024-07-08 at 17 44 07

I copied the pattern from the ion-ripple-effect docs.

An issue with this quick implementation is that the ripple effect doesn't respect the rounded corners of the button component, so you could see if you can resolve that.

@kwAsant kwAsant linked a pull request Jul 9, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Work on app features/modules good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/consistency with button animations IDEMSInternational/open-app-builder
2 participants
@jfmcquade @kwAsant