Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SyntagmaticFunction and subclasses. #2

Open
vletard opened this issue Feb 22, 2020 · 0 comments
Open

Merge SyntagmaticFunction and subclasses. #2

vletard opened this issue Feb 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@vletard
Copy link
Member

vletard commented Feb 22, 2020

Given the current type hierarchy, it seems that there is no real use of having Process, Actant and Quality to subclass SyntagmaticFunction apart from some degree of code clarity.
Indeed the three subclasses represent the same underlying object as a plain SyntagmaticFunction. Moreover there is a risk of unwanted parent class delegation (particularly for static similarly named methods).
The simplest option is to make subclasses methods to have distinct names from SyntagmaticFunction's.
A better choice is to completely merge all four classes into a single big one.

@vletard vletard added the enhancement New feature or request label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant