Consistency with integer/value ...

[fxlb]

We should do some changes for consistency:

git grep 'integer value' *.md | wc -l
6
git grep 'unsigned value' *.md | wc -l
30
git grep 'unsigned integer' *.md | wc -l
16
git grep 'unsigned integer value' *.md | wc -l
2
git grep '\<signed value' *.md | wc -l
1
git grep '\<signed integer' *.md | wc -l
1
git grep '\<signed integer value' *.md | wc -l
1

[fxlb]

Proposal:

s/unsigned value/unsigned integer/g
s/signed value/signed integer/g
s/unsigned integer value/unsigned integer/g
s/signed integer value/signed integer/g

[guyharris]

+1

and, as per #174, s/value/{appropriate signedness qualifier} integer/.

[fxlb]

+1

Is #175.

and, as per #174, s/value/{appropriate signedness qualifier} integer/.

Will be another PR.

[fxlb]

And also:

git grep 'integer value' '*.md'
draft-ietf-opsawg-pcaplinktype.md:518:* LINKTYPE Value: Indicates the integer value assigned for this LinkType.
draft-ietf-opsawg-pcapng.md:1233:* it stores the Interface Identifier as a 32-bit integer value.
draft-ietf-opsawg-pcapng.md:2465:Every Block is uniquely identified by a 32-bit integer value, stored

[fxlb]

draft-ietf-opsawg-pcapng.md:1233 * it stores the Interface Identifier as a 32-bit integer value.
Unsigned?
Yes (line 1282: * Interface ID (32 bits): an unsigned integer)

draft-ietf-opsawg-pcapng.md:2465 Every Block is uniquely identified by a 32-bit integer value, stored
Unsigned?

[guyharris]

draft-ietf-opsawg-pcapng.md:2465 Every Block is uniquely identified by a 32-bit integer value, stored Unsigned?

They're really enum values, just as link-layer types are, so in a sense it's irrelevant, and, unlike link-layer types, where the value is given in decimal, and anything 16-bit that goes beyond 32767 is clearly unsigned, the block type values are given in hex, and those are less often given as signed (-0x7fffffff), so that's less of a clear case.

But, by analogy to link-layer types, and to avoid people inadvertently sign-extending and causing problems, I'd vote for unsigned.

[fxlb]

Ok, this (and some others) are updated in PR #178.

[fxlb]

Done.