Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying reservoir locations as GRID_CELL_INDEX (rather than using ID) is confusing #110

Open
thurber opened this issue Feb 12, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@thurber
Copy link
Contributor

thurber commented Feb 12, 2024

Specifying reservoir locations as GRID_CELL_INDEX (rather than using ID) is confusing and counterintuitive for users. We should consider updating the expected input file format to always use and respect grid cell IDs, rather than trying to recast the internal ID as an arbitrary zero-based index. We currently handle this properly for the domain file, but not for the reservoir file (therefore making it even more confusing).

@thurber thurber added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant