Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colloc requests always seem to return empty tokenFrequencies #504

Closed
KCMertens opened this issue Mar 29, 2024 · 3 comments
Closed

Colloc requests always seem to return empty tokenFrequencies #504

KCMertens opened this issue Mar 29, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@KCMertens
Copy link
Member

KCMertens commented Mar 29, 2024

Unless I'm doing it wrong: http://svotmc10.ivdnt.loc/blacklab-server/opensonar/hits/?first=0&number=20&patt=%5Bword%3D%22schip%22%5D&calc=colloc
No matter what word I try. When requesting xml there's also a strange <script/> tag present.

@KCMertens KCMertens added the bug label Mar 29, 2024
@KCMertens KCMertens changed the title Colloc requests always seem to return empty word lists: Colloc requests always seem to return empty tokenFrequencies Mar 29, 2024
@KCMertens
Copy link
Member Author

Aha, nevermind, it seems wordsaroundhit is required.

@jan-niestadt
Copy link
Member

Glad you've found a workaround, but I'd still like to take look at this; the context (formerly wordsaroundhit) parameter should probably have a reasonable default value, and there shouldn't be a <script/> tag.

@jan-niestadt jan-niestadt reopened this Mar 29, 2024
@jan-niestadt jan-niestadt self-assigned this Mar 29, 2024
@jan-niestadt jan-niestadt added this to the v4.0 milestone Mar 29, 2024
@jan-niestadt
Copy link
Member

Fixed in b453696; now uses either wordsaroundhit, context or a default value.

The <script/> things seems to be a Chrome bug, it's not in the source and Firefox doesn't show it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants