Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Consistency (AU) : feature does not correspond to edge in topological structure #990

Open
Dnoack49 opened this issue Aug 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Dnoack49
Copy link

Dnoack49 commented Aug 3, 2023

Dear all,

When validating the following AdministrativeBoundary-Dataset

I receive the following Error-Message in the Module "Conformance class: Dataconsistency, Administrative Units / Boundary/ au-dc.f.1 The geometry of each instance administrattive boudnary corresponds to an edge in the topological structure formed by the complete boundary graph, including the boundaries of all levels"

The feature does not correspond to an edge in the topological structure formed by the complete boundary graph of all AdministrativeUnit features. It is not on the boundary of any AdministrativeUnit in the dataset.

grafik

When looking at the example object with ID AdministrativeBoundary_DEBBATP00000lDIz :

The AdministrativeBoundary however is on the boundary of the AdministrativeUnit

grafik

Or is the reason the nilReason-Value in the adminUnit-Reference?

I would be thankful for an advice.

Kind regards

@github-actions github-actions bot added this to To do in Validator issues Aug 3, 2023
@fabiovinci
Copy link
Collaborator

Dear @Dnoack49,

thank you for the issue, we will have a look asap.

@fabiovinci fabiovinci self-assigned this Aug 4, 2023
@Dnoack49
Copy link
Author

Any news on this issue?

@fabiovinci
Copy link
Collaborator

Dear @Dnoack49,

sorry for the late reply.
The issue is due to the fact that you are validating only the "AdministrativeBoundary" feature type and the validator looks for an "AdministrativeUnit" inside the dataset itself for the check about the boundary requirements.

Regarding the admUnit attribute, you should populate it to document the association of the boundary with the unit, but since it is voidable the validator doesn't check it.

We are considering introducing a manual check in the related test, to handle situations like yours.

@fabiovinci fabiovinci added enhancement New feature or request and removed under analysis labels Dec 5, 2023
@fabiovinci fabiovinci removed their assignment Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants