Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixedstep config validation missing #255

Open
lausdahl opened this issue Jun 10, 2021 · 0 comments
Open

Fixedstep config validation missing #255

lausdahl opened this issue Jun 10, 2021 · 0 comments
Labels
bug maestrov2 Will be considered for MaestroV2

Comments

@lausdahl
Copy link
Contributor

The test examples contains config.json data which is send in through expansion but the data they contain is not even related to the model loaded through the env.json file. These files should be validated. All parameters must be resolvable otherwise you may not discover that some of these are never set.

Exmaple initialize_singleWaterTank:

{
  "fmus": {
    "{x1}": "target/test-classes/watertankcontroller-c.fmu",
    "{x2}": "target/test-classes/singlewatertank-20sim.fmu"
  },
  "connections": {
    "{x1}.crtlInstance.valve": [
      "{x2}.wtInstance.valvecontrol"
    ],
    "{x2}.wtInstance.level": [
      "{x1}.crtlInstance.level"
    ]
  },
  "algorithm": {
    "type": "fixed-step",
    "size": 0.001
  },
  "end_time": 10.0
}

does not match:

{
  "parameters": {
    "{crtl}.crtlInstance.maxlevel": 2,
    "{crtl}.crtlInstance.minlevel": 1
  },
  "verifyAgainstProlog": true,
  "stabilisation": true,
  "fixedPointIteration": 5,
  "absoluteTolerance": 0.1,
  "relativeTolerance": 0.1
}
@lausdahl lausdahl added bug maestrov2 Will be considered for MaestroV2 labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maestrov2 Will be considered for MaestroV2
Projects
None yet
Development

No branches or pull requests

1 participant