Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder settings state is not passed from parent to child. #356

Open
FrederikPM opened this issue Nov 12, 2021 · 2 comments
Open

Builder settings state is not passed from parent to child. #356

FrederikPM opened this issue Nov 12, 2021 · 2 comments

Comments

@FrederikPM
Copy link
Collaborator

In the Sigver plugin the builder settings are passed with their default value although they are set to different values in the parent.

@CThuleHansen
Copy link
Contributor

CThuleHansen commented Nov 18, 2021

I think we should make an interface to the expansion plugins, such that it is expanded directly instead of Maestro Machinery to do it. This would avoid these issues.

@FrederikPM what sort of issues are you seeing because of this?

Of course, this means that the support for writing expand in a MaBL specification by hand will deteriorate over time.. @lausdahl input on this?

@FrederikPM
Copy link
Collaborator Author

@CThuleHansen at the moment it does not cause any issues. I just discovered this when looking into a separate issue.

@FrederikPM FrederikPM changed the title Builder settings are reset when passed from parent to child. Builder settings state is not passed from parent to child. Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants