Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractor models to so that init takes individual fields and make a from_dict class method #4

Open
vlee489 opened this issue Oct 8, 2024 · 0 comments
Open

Refractor models to so that init takes individual fields and make a from_dict class method #4

vlee489 opened this issue Oct 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@vlee489
Copy link
Member

vlee489 commented Oct 8, 2024

A number of models use the old model design this issue is to refractor the following

  • __init__() should take individual fields and not a single dict
  • Make a from_dict() classmethod that allow object creation from data provided from a dict
@vlee489 vlee489 added the enhancement New feature or request label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vlee489