-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra settings for limiting search facets 10570 #10590
Conversation
…n limiting the search-related bells and whistles luxuries - such as the facets and the object counts for the types left unchecked in the object types facets - more granularly. The default behavior is left intact in all cases. #10570
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this seems great. I left a comment about naming and docs. I could simply be confused.
|
||
Similar to the above, but will disable the facets for Guest users only. | ||
|
||
:DisableSolrFacetsForAnonymousUsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about :DisableSolrFacetsForInitialRequests
instead?
Perhaps I'm misunderstanding the paragraph below, but when set to true, people would be affected by this (and not see the facets) the first time they visit a Dataverse installation, right? Unfortunately, these people would get a less rich, facetless experience, if I understand correctly, when this is set to true for the purpose of mostly avoiding loads from bots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for human UI users the page will only be facet-less on the first load.
I could rename it :DisableSolrFacetsWithoutJSESSION
, to just literally spell out what it does.
It's important to keep in mind that these are simply extra tools to have around for desperate situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, :DisableSolrFacetsWithoutJsession
(or whatever cApiTaLization) sounds good to me. 😄
Co-authored-by: Philip Durbin <[email protected]>
This comment has been minimized.
This comment has been minimized.
@landreev - a couple things to get this through review:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Build fails due to solr changes, so should be merged/tests rerun as part of QA once the solr PR is in.
I was about to repeat that if there was any doubt whatsoever about this pr, it was entirely ok to leave it out of 6.3... but happy to see that it's been merged! |
What this PR does / why we need it:
This gives an instance admin some extra flexibility in limiting the search facets, as shown on the pages, to users and/or bots. Could be another useful tool to have in case of a search engine disaster. Explained in the guide.
Which issue(s) this PR closes:
Closes #10570
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: