Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API: File dataset_name and dataset_citation refer to different versions #10735

Closed
ekraffmiller opened this issue Jul 31, 2024 · 2 comments · Fixed by #11051
Closed

Search API: File dataset_name and dataset_citation refer to different versions #10735

ekraffmiller opened this issue Jul 31, 2024 · 2 comments · Fixed by #11051
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Milestone

Comments

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Jul 31, 2024

What steps does it take to reproduce the issue?

  1. Create a dataset with a file
  2. Publish the dataset
  3. Edit the title of the dataset
  4. use the search API to get the file, for example, http://localhost:8000/api/v1/search?q=*&type=file&sort=date&order=desc&per_page=10&start=0&subtree=root
  5. The title in the dataset_name field doesn't match the title in the dataset_citation (see screenshot)
  • When does this issue occur?
    When dataset metadata is edited, but not file metadata

  • Which page(s) does it occurs on?
    N/A

  • What happens?

  • To whom does it occur (all users, curators, superusers)?
    All

  • What did you expect to happen?
    The dataset_citation field should be for the released version of the file, not the draft version

Which version of Dataverse are you using?
6.2

Any related open or closed issues to this bug report?

Screenshots:

Screenshot 2024-07-31 at 1 28 41 PM
@ekraffmiller ekraffmiller added the Type: Bug a defect label Jul 31, 2024
@ekraffmiller ekraffmiller changed the title Search API: File Citation dataset_name and dataset_citation refer to different versions Search API: File dataset_name and dataset_citation refer to different versions Jul 31, 2024
@sbarbosadataverse sbarbosadataverse added the Size: 3 A percentage of a sprint. 2.1 hours. label Aug 21, 2024
@sbarbosadataverse sbarbosadataverse moved this to SPRINT READY in IQSS Dataverse Project Aug 21, 2024
atniph pushed a commit to dsd-sztaki-hu/dataverse that referenced this issue Nov 4, 2024
atniph pushed a commit to dsd-sztaki-hu/dataverse that referenced this issue Nov 8, 2024
atniph pushed a commit to dsd-sztaki-hu/dataverse that referenced this issue Nov 18, 2024
atniph pushed a commit to dsd-sztaki-hu/dataverse that referenced this issue Nov 18, 2024
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 22, 2024
@stevenwinship stevenwinship self-assigned this Nov 25, 2024
@stevenwinship stevenwinship moved this from This Sprint 🏃‍♀️ 🏃 to In Progress 💻 in IQSS Dataverse Project Nov 25, 2024
@stevenwinship
Copy link
Contributor

Just to be clear. Is this a true bug? Per the Search API Documentation these values are not guarantied to be the same:

image

@qqmyers
Copy link
Member

qqmyers commented Nov 25, 2024

Looks like a bug that got copied to the documentation to me. We shouldn't be leaking draft info to someone who can't see the draft version.

@stevenwinship stevenwinship added Size: 10 A percentage of a sprint. 7 hours. and removed Size: 3 A percentage of a sprint. 2.1 hours. labels Nov 26, 2024
@stevenwinship stevenwinship removed their assignment Nov 26, 2024
@sekmiller sekmiller assigned sekmiller and unassigned sekmiller Dec 5, 2024
@pdurbin pdurbin added this to the 6.6 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants