IQSS/11046 - Text changes for Anonymized URLs

[qqmyers]

What this PR does / why we need it: Simple text change to sync with the actual functionality. Also deleting two unused entries.

Which issue(s) this PR closes:

• Closes Incorrect info re: anonymous URLs #11046

Special notes for your reviewer:

Suggestions on how to test this: Simple text change - to test if desired, create a draft dataset, then, in the Edit menu, click Preview URL and verify that the second paragraph for the Anonymous Preview does not say "and will be accessible if they're not restricted"

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[ofahimIQSS]

continuous-integration/jenkins/pr-merge is failing on this one.

[ofahimIQSS]

verified and no issues found during testing, can we please get this reviewed and approved so I can merge it?

[jggautier]

Hey @ofahimIQSS. If it helps, I could review this by just looking at the screenshot you posted and confirming that the second paragraph in the popup's Anonymous Preview section does not say "and will be accessible if they're not restricted".

The text isn't in the popup's Anonymous Preview section when I bring up the popup on Demo Dataverse.

[ofahimIQSS]

@jggautier Yes, i deployed this to internal so it wouldn't be on demo

[jggautier]

Ah, I think someone else enabled Anonymous Preview URLs on Demo Dataverse after Demo Dataverse was updated to v6.5:

But are you also saying that this should be tested using internal at https://dataverse-internal.iq.harvard.edu? I just checked out the popup there and can see that it matches what's on Demo Dataverse and does include the text "and will be accessible if they're not restricted".

[ofahimIQSS]

Ah, I think someone else enabled Anonymous Preview URLs on Demo Dataverse after Demo Dataverse was updated to v6.5:

But are you also saying that this should be tested using internal at https://dataverse-internal.iq.harvard.edu? I just checked out the popup there and can see that it matches what's on Demo Dataverse and does include the text "and will be accessible if they're not restricted".

yes that would make sense as I was testing in internal and pushed out a different PR to the environment which would mean this PR wasn't deployed. We can work together to test this if you want today :)

[jggautier]

Cool okay. Let me know what I should do.

[jggautier]

Thanks for following up on Slack @ofahimIQSS!

In the "Unpublished Dataset Preview URL" popup that I see on internal, the text "and will be accessible if they're not restricted" is not there, just like in the screenshot that you shared yesterday.

[jggautier]

When this was redesigned in #10961, I made a change to the last sentence in the popup. Right now it reads "Anonymized Access is not available once a version of the dataset has been published."

In a comment in that PR, I changed that last sentence to "You won't be able to create an Anonymous Preview URL once a version of this dataset has been published."

I just noticed that that change wasn't made. Maybe because I forgot to bold that text in my comment like I did with other text changes in my comment.

Discussing or fixing this is outside of this PR's scope, but could we at least not capitalize the text "Anonymous Access" in that last sentence. I imagine that it's capitalized because at one point we were considering that being the name of the feature, but it's not anymore.

If we can't change "Anonymous Access" to "anonymous access" in this PR, I can open a new issue about changing that last sentence.

[jggautier]

Ah, I was about to open a GitHub issue about changing that last sentence, but in Slacking with @scolapasta, we realized that you had already changed it @qqmyers. Thanks!

[ofahimIQSS]

Text changes verified - merging PR