-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update actions/checkout 2->3+ #11050
Merged
ofahimIQSS
merged 4 commits into
IQSS:develop
from
QualitativeDataRepository:Update_action/checkout
Dec 20, 2024
Merged
Update actions/checkout 2->3+ #11050
ofahimIQSS
merged 4 commits into
IQSS:develop
from
QualitativeDataRepository:Update_action/checkout
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR from @carlsonp might help us know when to bump versions in the GitHub Actions we use: |
bencomp
approved these changes
Nov 28, 2024
This was referenced Dec 16, 2024
pdurbin
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed short round of regression testing in internal - no issues uncovered. Screen.Recording.2024-12-20.at.12.01.00.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 12
FY25 Sprint 12 (2024-12-04 - 2024-12-18)
Size: 3
A percentage of a sprint. 2.1 hours.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: I'm seeing warnings that actions/checkout 2 uses the deprecated node 12 and an update to at least v3 using node 16 is needed. There is a v4 (node 20), and, in looking through the code, I see several other v3 actions that have v4 versions.
This PR updates all of these to v4.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Guessing this is like the earlier #10997 PR in that we're just looking to make sure things don't break. If they do, we can either address the issue or roll-back the relevant change. (The shift from checkout v2 is one we should keep so we stop using node 12, but everything else is ~optional.)
The changes are across many tasks - building the guides, review dog, pushing containers, pushing the spi, etc.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: