Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout 2->3+ #11050

Merged

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 25, 2024

What this PR does / why we need it: I'm seeing warnings that actions/checkout 2 uses the deprecated node 12 and an update to at least v3 using node 16 is needed. There is a v4 (node 20), and, in looking through the code, I see several other v3 actions that have v4 versions.

This PR updates all of these to v4.

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this: Guessing this is like the earlier #10997 PR in that we're just looking to make sure things don't break. If they do, we can either address the issue or roll-back the relevant change. (The shift from checkout v2 is one we should keep so we stop using node 12, but everything else is ~optional.)

The changes are across many tasks - building the guides, review dog, pushing containers, pushing the spi, etc.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Nov 25, 2024
@pdurbin
Copy link
Member

pdurbin commented Nov 25, 2024

This PR from @carlsonp might help us know when to bump versions in the GitHub Actions we use:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Approved. Sadly, we have no way to test this so let's revert if anything breaks.

Also, as @qqmyers notes, we should close the open PRs (after we merge this and confirm nothing is broken?) created by dependabot that have the same fixes (#11100 etc.) at some point.

@ofahimIQSS ofahimIQSS self-assigned this Dec 20, 2024
@ofahimIQSS
Copy link
Contributor

Performed short round of regression testing in internal - no issues uncovered.

Screen.Recording.2024-12-20.at.12.01.00.PM.mov

@ofahimIQSS ofahimIQSS removed their assignment Dec 20, 2024
@ofahimIQSS ofahimIQSS merged commit 09d0b83 into IQSS:develop Dec 20, 2024
6 checks passed
@pdurbin pdurbin added this to the 6.6 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Merged 🚀
Development

Successfully merging this pull request may close these issues.

5 participants