Collection Level "Assign role" API error message should specify: User already has this role, and not include "dataset" (which is incorrect)

[sbarbosadataverse]

What steps does it take to reproduce the issue?
When using this Native AP

If the user already has the role, the error message reads "{"status":"ERROR","message":"User already has this role for this dataset"}% instead of "collection"

• When does this issue occur?
  When a user already has the role type in question

• Which page(s) does it occurs on?

• What happens?

• To whom does it occur (all users, curators, superusers)?
  superuser, curators, anyone with permission to run this script on a collection level

• What did you expect to happen?

correct error message: "User already has this role" remove "datasets" and no need to mention dataverse or collection

Which version of Dataverse are you using?

most recent

Any related open or closed issues to this bug report?
NO

Screenshots:

[pdurbin]

I tested this as of a789342 and can easily reproduce it with the following test by duplicating the call to grant a role on a collection:

% git diff src/test
diff --git a/src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java b/src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java
index c1273fba9f..0f8b8b79bd 100644
--- a/src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java
+++ b/src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java
@@ -299,6 +299,10 @@ public class DatasetsIT {
         Response grantRole = UtilIT.grantRoleOnDataverse(dataverseAlias, DataverseRole.DS_CONTRIBUTOR, AuthenticatedUsers.get().getIdentifier(), apiToken);
         grantRole.prettyPrint();
         assertEquals(OK.getStatusCode(), grantRole.getStatusCode());
+        grantRole = UtilIT.grantRoleOnDataverse(dataverseAlias, DataverseRole.DS_CONTRIBUTOR, AuthenticatedUsers.get().getIdentifier(), apiToken);
+        grantRole.prettyPrint();
+        assertEquals(OK.getStatusCode(), grantRole.getStatusCode());

This checking for duplicate roles is relatively new, added in 6.3 with this PR (my bad for not catching this in code review):

• API: Handling creation of duplicate role for a dataset object  #10474

As @sbarbosadataverse said, the easiest fix is to shorten the message to "User already has this role". One thing to note however, is that in the test above we are assigning a group rather than a user to a role. So "User or group already has this role" is a bit more accurate. We could also vary the messages, of course ("Group already has this role on this file" or whatever), but perhaps that's overkill. We could even simply say "Role has already been granted." 🤷

I'm going to go ahead and give this a size of 3.