Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Text Spacing in Astronomy Metadata Fields #2622

Open
posixeleni opened this issue Oct 5, 2015 · 8 comments
Open

Fix Text Spacing in Astronomy Metadata Fields #2622

posixeleni opened this issue Oct 5, 2015 · 8 comments
Labels
Feature: Metadata Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.

Comments

@posixeleni
Copy link
Contributor

Field Display Name: RedshiftType -> Redshift Type (also fix in the field description as well)

Controlled Vocabulary for Type:

  • EventList -> Event List
  • LightCurve -> Light Curve
  • PrettyPicture -> Pretty Picture
  • ValuePair -> Value Pair

Also a good opportunity to add identifiers in the controlled vocabulary

@posixeleni posixeleni self-assigned this Oct 5, 2015
@posixeleni posixeleni added this to the 4.3 milestone Oct 5, 2015
@mercecrosas mercecrosas modified the milestones: 4.3, In Review Nov 30, 2015
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Jun 5, 2017

Still a bug as of 4.6.1. Here's the file: https://github.com/IQSS/dataverse/blob/v4.6.1/scripts/api/data/metadatablocks/astrophysics.tsv

#2551 is related.

sekmiller added a commit that referenced this issue Jun 5, 2017
@jggautier jggautier self-assigned this Jun 28, 2017
@pdurbin pdurbin added the User Role: Depositor Creates datasets, uploads data, etc. label Jul 4, 2017
@jggautier jggautier removed their assignment Jul 19, 2019
@johnhuck
Copy link
Contributor

Enquiring minds are curious about the source of the controlled vocabulary for astrotype.

@pdurbin
Copy link
Member

pdurbin commented Nov 15, 2019

@johnhuck
Copy link
Contributor

thanks, @pdurbin - yes, but where did this list of type values originate? is it from a standard? was it created locally?

@pdurbin
Copy link
Member

pdurbin commented Nov 15, 2019

@johnhuck
Copy link
Contributor

@pdurbin Of course! I'm sorry, I thought we'd already checked there. Looks like the terms are primarily from the VO schema, rather than the IVOA (there's some overlap between the VO and IVOA types, but not much, which is curious).

I don't see the values Figure, PrettyPicture, Documentation, and Press Release in the VO list (although IVOA has Press), but the VO document says the list is extensible, so I guess we can assume they were introduced somewhere along the way. Perhaps not important at this point. Thanks for the assist!

@pdurbin pdurbin added the hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ label Sep 21, 2020
@pdurbin pdurbin removed the hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ label Sep 29, 2022
@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
@github-project-automation github-project-automation bot moved this from 🚧 Dev by Recherche Data Gouv to Done in Recherche Data Gouv Aug 20, 2024
@jggautier
Copy link
Contributor

I was asked to propose next steps based on discussion in the related pull request that @sbondka created at #10206.

I think that we should work with experts, like contacts at Harvard's CfA and folks who worked on that VO metadata standard, to figure out how the vocab terms should appear when researchers choose them, and to figure out how identifiers, a blockUri and/or termUris should be added to the metadata block.

@scolapasta suggested closing the PR, and that we could reopen it if we decide to build on it. I agreed.

We'll meet with @cmbz next week to review this.

@jggautier jggautier reopened this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metadata Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants