Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pip install #90

Merged
merged 40 commits into from
Jun 27, 2024
Merged

Fixing pip install #90

merged 40 commits into from
Jun 27, 2024

Conversation

AnthonyLim23
Copy link
Collaborator

@AnthonyLim23 AnthonyLim23 commented Feb 29, 2024 •
edited
Loading

There was a bug that meant that the pip packages were missing the setup helpers needed for building quickBayes. I have fixed this by updating the setup.py to include the required file as part of the package.

Fixes #89

@AnthonyLim23 AnthonyLim23 added the bug Something isn't working label Feb 29, 2024
@AnthonyLim23
#refs 89 first go at fixing pip install
4057435
@AnthonyLim23
#refs 89 first go at fixing pip install
fb422c7
@AnthonyLim23
#refs 89 first go at fixing pip install
f481940
@AnthonyLim23
#refs 89 first go at fixing pip install
39d78e1
@AnthonyLim23
#refs 89 first go at fixing pip install
9f2f4a1
@AnthonyLim23
#refs 89 first go at fixing pip install
e6bff1f
@AnthonyLim23
#refs 89 first go at fixing pip install
52fcd4e
@AnthonyLim23
#refs 89 first go at fixing pip install
ba7863e
@AnthonyLim23
#refs 89 first go at fixing pip install
f10aabc
@AnthonyLim23
refs #89 move to pyproject.toml
4278811
@AnthonyLim23
refs #89 move to pyproject.toml
c4abcc9
@AnthonyLim23
refs #89 move to pyproject.toml
f005f3c
@AnthonyLim23
refs #89 move to pyproject.toml
1f7b76c
@AnthonyLim23
refs #89 move to pyproject.toml
bf20f7c
@AnthonyLim23
refs #89 move to pyproject.toml
bb4a8f7
@AnthonyLim23
refs #89 move to pyproject.toml
6b47958
@AnthonyLim23
refs #89 move to pyproject.toml
0103169
@AnthonyLim23
refs #89 move to pyproject.toml
e7e809b
@AnthonyLim23
refs #89 move to pyproject.toml
a1d4cdf
@AnthonyLim23
refs #89 move to pyproject.toml
dc63eeb
@AnthonyLim23
refs #89 move to pyproject.toml
14e501e
@AnthonyLim23
refs #89 move to pyproject.toml
e0278c5
@AnthonyLim23
refs #89 move to pyproject.toml
a906416
@AnthonyLim23
refs #89 move to pyproject.toml
0ec7dca
@AnthonyLim23
refs #89 move to pyproject.toml
7236df3
@AnthonyLim23
refs #89 move to pyproject.toml
4f6976c
@AnthonyLim23
refs #89 move to pyproject.toml
05cdd3a
@AnthonyLim23
refs #89 move to pyproject.toml
5a01910
@AnthonyLim23 AnthonyLim23 mentioned this pull request May 28, 2024
Open
@jess-farmer jess-farmer self-requested a review June 27, 2024 12:22
jess-farmer
jess-farmer approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@jess-farmer jess-farmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and installation works in a fresh virtualenv

@AnthonyLim23 AnthonyLim23 merged commit be48ef5 into main Jun 27, 2024
15 checks passed
@AnthonyLim23 AnthonyLim23 deleted the 89_missing_tools branch June 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jess-farmer jess-farmer jess-farmer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JOSS review: installation error
2 participants
@AnthonyLim23 @jess-farmer