-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox is failing 2 out of 4 tests..(??) #3
Comments
Thanks, I will have a look. Maybe there is something wrong with the tests. @mosoriob do you have time to look at this? Otherwise I'll have a look during the weekend. In any case, @riccardoAlbertoni the important thing is that you got the API working (even though I would like to have this working for you as well) |
You need to modify the tests because they use a dummy id.
You can found good examples in the model catalog api |
Thanks @mosoriob I will review and update the documentation in case it's necessary to reflect this. |
@riccardoAlbertoni if you want to make sure the tests run, I would select an example of a band and an example of a genre and give it a try. Just making sure you complete the notebook :) |
I have updated the notebook. Thanks a lot. In the notebook, you can find some suggestions on how you could improve the documentation on that specific point if you want. |
Hi everyone, Not sure if this is just related to my system, but I had some problem running the experiments with tox. The error I got was: I solved the problem by quickly changing the permissions setting of the server folder. Eventually, I also tried running the experiments with Everything else seems to run/to build correctly: I could run the first part flawlessly (see here and here), for the second one I have to thank @riccardoAlbertoni and the authors for the great work, I was a bit lost when I had to run the server, but the commands in @riccardoAlbertoni notebook colab notebook were super helpful to put the server up. My configuration: OS: Ubuntu 20.04 |
Thanks @riccardoAlbertoni , @fbvinid |
I updated the documentation for the testing part: https://oba.readthedocs.io/en/latest/test/ |
Hi @dgarijo :), I think the most difficult part for me was running It might be worth adding a visual example here on how to use the APIs, but I don't think that is a big issue. Apart from the fact that it is impossible to run |
Got it, thanks! |
Tox seems to fail 2 out of 4 tests, though I think I have tested the same things manually via http://localhost:8080/v1.3.0/ui/ and I am quite confident that everything is working... instructions I used and the related screenshots in the last sections of the notebook ([1] or [2]).
@dgarijo and @mosoriob: Any chance that the tests get misconfigured? Or have I misunderstood the instructions?
[1]https://colab.research.google.com/drive/1XKk_feh4Eb-fC3FGQ9kGwfiP7KieswT3?usp=sharing
[2]https://github.com/riccardoAlbertoni/ISWC_reproducibility607/blob/master/Reproducing607.ipynb
The text was updated successfully, but these errors were encountered: