Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring users plugin in webserver #6913

Open
pcrespov opened this issue Dec 6, 2024 · 0 comments
Open

Refactoring users plugin in webserver #6913

pcrespov opened this issue Dec 6, 2024 · 0 comments
Assignees
Milestone

Comments

@pcrespov
Copy link
Member

pcrespov commented Dec 6, 2024

Database

users.id
users.name
users.first_name
users.last_name

So i guess I could move it to

users.id
users.user_name
users.first_name
users.last_name

Models

  • Update = PATCH, Replace = PUT.
    In any case, I notice we get confused between update and replace. I guess it means we should perpahs start using Patch.

So the model names should be : $ResourceName$Operation where Operation in [Get, Update, Replace, Delete, Create]. Perhaps instead of Update we should use Patch?

Exception handling

  • mappers

Originally posted by @pcrespov in #6904 (comment)

@pcrespov pcrespov self-assigned this Dec 6, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant