BUG: "History" details are being overwritten when a modification to a booking is submitted.

[ss12430]

See “History” section in screenshot below.

This booking was approved on 3/20. On 3/21 at 2:29pm Erik made an edit to the end time of the reservation, and the timestamp for Requested, Pending, and Approved was overwritten to the time that the modification was made. Under “User” it still has the reservation holder's email which could make it appear that the reservation holder made the edit rather than Erik. Would like a way to add to the history rather than write over it, like adding a 4th line when an edit is made. Should also talk about what happens with a small edit like this, versus a reservation holder editing something that causes the request to go through the approval process again.

[nopivnick]

@ss12430 this is a bug (Modifications are being treated like Edits in so far as the timestamp of the modification is being written to all statuses) and a feature request (you want a "History" with more granular details) which is a much heavier lift.

"History" is a bit of a misnomer in so far as it only represents progression along a linear sequence of changes to status, not every change that's made to a booking.

splitting this into two cards (the bug and the feature request). we'll need to revisit which of the current feature requests with priority HIGH can be downgraded in terms of urgency.

[ss12430]

Sounds good Noah, I'll add this to the agenda to talk through at our next meeting

…

On Fri, Mar 21, 2025 at 4:52 PM Noah Pivnick ***@***.***> wrote: @ss12430 <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ss12430&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=g_7O0AyrOuibqE8dcHbY-rhlJDf9nvXoJRcaFW5vDRg&e=> this is a bug (Modifications are being treated like Edits in so far as the timestamp of the modification is being written to all statuses) and a feature request (you want a "History" with more granular details) which is a much heavier lift. "History" is a bit of a misnomer in so far as it only represents progression along a linear sequence of changes to status, not every change that's made to a booking. splitting this into two cards (the bug and the feature request). we'll need to revisit which of the current feature requests with priority HIGH can be downgraded in terms of urgency. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ITPNYU_booking-2Dapp_issues_658-23issuecomment-2D2744423633&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=TSSjLLcpEPqA7qYDBah72hgOU8sCRivGmgQpAaUZSC8&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKKAKOECRLXT6LVFYXTQEWD2VR3W7AVCNFSM6AAAAABZQ2ZX4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBUGQZDGNRTGM&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=W7UmO6AwdloGo_elKGPlK07_Em_ltnqDdUGGXivi_mI&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: nopivnick]*nopivnick* left a comment (ITPNYU/booking-app#658) <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ITPNYU_booking-2Dapp_issues_658-23issuecomment-2D2744423633&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=TSSjLLcpEPqA7qYDBah72hgOU8sCRivGmgQpAaUZSC8&e=> @ss12430 <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ss12430&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=g_7O0AyrOuibqE8dcHbY-rhlJDf9nvXoJRcaFW5vDRg&e=> this is a bug (Modifications are being treated like Edits in so far as the timestamp of the modification is being written to all statuses) and a feature request (you want a "History" with more granular details) which is a much heavier lift. "History" is a bit of a misnomer in so far as it only represents progression along a linear sequence of changes to status, not every change that's made to a booking. splitting this into two cards (the bug and the feature request). we'll need to revisit which of the current feature requests with priority HIGH can be downgraded in terms of urgency. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ITPNYU_booking-2Dapp_issues_658-23issuecomment-2D2744423633&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=TSSjLLcpEPqA7qYDBah72hgOU8sCRivGmgQpAaUZSC8&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKKAKOECRLXT6LVFYXTQEWD2VR3W7AVCNFSM6AAAAABZQ2ZX4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBUGQZDGNRTGM&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hvLPERRD5qd65mOdX297GA&m=cSt9pcWXdlnTCUFpLcuvJQmWwSW_F6N2r0OEjkuOc_3pMAcEwwVQfbIS89P6p2Il&s=W7UmO6AwdloGo_elKGPlK07_Em_ltnqDdUGGXivi_mI&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Samantha Renshi Skinner (she/her)* Operations Director 370J Media Commons | Office of the Provost 370 Jay Street #515 | O: (212) 998-2380 ext 82380 Website: bit.ly/370JMediaCommons Community Newsletter Sign up: bit.ly/370JMCNewsletter