-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalizing fitting algorithm to MPO-MPO multiplication #37
Comments
Good question. Ultimately we plan to allow more general inputs to A minimal thing you can do is just convert your MPO to an MPS (there isn't any restriction that MPS must have only one site index per site), and see what breaks. At some point I tested this out for using TDVP to evolve a density matrix. I think it all worked after I generalized some of the projected MPO code to handle the "dangling" indices properly: ITensor/ITensors.jl@0101936 |
Thank you for the reply.
That'd be great! In the meantime, I have just made a quick dirty hack to ITensorTDVP.jl and ITensors.jl. I had to extend |
Agreed with Matt's answer about mapping to the MPS type and back, and tweaking the code to handle doubled site indices. Sounds like it worked! So do I understand from your code, literally the only change needed was defining replacebond!, and the rest just worked? That's great if so. |
Correct! Let me clean up the code. |
Here is a small patch with a test: Changing a few lines in |
Yes a PR would be great. Thanks! And for now you could put the MPO version of |
I am a bit confused. Do we need the MPO version of |
Thank you for developing the nice library!
I am wondering how to generalize the fitting algorithm to MPO-MPO multiplication. I am slowly understanding the internal structure of this library. This could be achieved by generalizing
ProjMPOApply
.https://github.com/ITensor/ITensorTDVP.jl/blob/main/src/projmpo_apply.jl
But, the function
tdvp
is specialized toMPS
. I am not sure if this restriction is strict. Is generalizing it toMPO
possible technically?The text was updated successfully, but these errors were encountered: