-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sample
type agnostic and GPU compatible
#93
Conversation
sample
type agnostic and GPU compatible
Thanks for the quick PR! This is subtle to test right now, we have to set up the tests in this repository to run on GPUs, I guess we'll address that in future PRs. |
@mtfishman I can look around other code in |
Let me know if you want some help with that @kmp5VT. I'd be willing to spend some time on that. |
Thanks @kmp5VT. Also it would be great to start switching some tests over to being able to test on GPU, looping over device backends the same way we do in the NDTensors/ITensors tests. For now it could just test using JLArrays, but ultimately we should also set things up with Jenkins to run the tests on GPUs. |
@tipfom I'll merge once you address the comment I made above about changing |
@mtfishman I've replaced all occurances of |
Thanks! |
sample
type agnostic and GPU compatiblesample
type agnostic and GPU compatible
Fixed the issue of
sample
mentioned in #92.Closes #92.