Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sample type agnostic and GPU compatible #93

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

tipfom
Copy link
Contributor

@tipfom tipfom commented Nov 13, 2024

Fixed the issue of sample mentioned in #92.

Closes #92.

src/mps.jl Outdated Show resolved Hide resolved
@mtfishman mtfishman changed the title Made sample type agnostic and CUDA compatible Made sample type agnostic and GPU compatible Nov 13, 2024
@mtfishman
Copy link
Member

Thanks for the quick PR! This is subtle to test right now, we have to set up the tests in this repository to run on GPUs, I guess we'll address that in future PRs.

@kmp5VT
Copy link

kmp5VT commented Nov 13, 2024

@mtfishman I can look around other code in ITensorMPS to see if there is more implicit Float64 typing and open another PR if there is. Thank you @tipfom for your PR!

@tipfom
Copy link
Contributor Author

tipfom commented Nov 13, 2024

Let me know if you want some help with that @kmp5VT. I'd be willing to spend some time on that.

@mtfishman
Copy link
Member

Thanks @kmp5VT. Also it would be great to start switching some tests over to being able to test on GPU, looping over device backends the same way we do in the NDTensors/ITensors tests. For now it could just test using JLArrays, but ultimately we should also set things up with Jenkins to run the tests on GPUs.

@mtfishman
Copy link
Member

@tipfom I'll merge once you address the comment I made above about changing promote_itensor_eltype to scalartype.

@tipfom
Copy link
Contributor Author

tipfom commented Nov 15, 2024

@mtfishman I've replaced all occurances of promote_itensor_eltype by scalartype. Hope that's okay; sorry for the delay.

@mtfishman
Copy link
Member

@mtfishman I've replaced all occurances of promote_itensor_eltype by scalartype. Hope that's okay; sorry for the delay.

Thanks!

@mtfishman mtfishman merged commit f5dee09 into ITensor:main Nov 15, 2024
8 of 9 checks passed
@mtfishman mtfishman changed the title Made sample type agnostic and GPU compatible Make sample type agnostic and GPU compatible Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sample in mps.jl broken when using CUDA
3 participants