Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build diag-client lib on windows platform #35

Open
Iandiehard opened this issue Sep 22, 2023 · 4 comments
Open

Build diag-client lib on windows platform #35

Iandiehard opened this issue Sep 22, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Iandiehard
Copy link
Owner

Description:-

This story targets to build diag-client-lib on windows platform

@Alexpux
Copy link

Alexpux commented Feb 26, 2024

Hi! I'm be able to build diag-client library on Windows using MINGW-W64 GCC/CLANG compilers using your pull request for TLS support. Only one issue with building is calling pthread_setname_np.

@Iandiehard
Copy link
Owner Author

Iandiehard commented Feb 27, 2024

Hello @Alexpux ,

Thanks for trying to build diag-client-lib on windows platform.

I thought pthread_setname_np is a common function for setting thread name and can be used for windows too. Did you fix this issue when building it on windows?

Also Did you also build boost library for windows ? was it straight forward or some additional steps are needed?

If you are interested, I would request you to create a pull request on any extra changes you made to build diag-client-lib on windows. This shall also ease up my job :)

Just FYI:-
The pull request for TLS support may not work as I have not yet tested it. So I would suggest to stick to master right now

@Alexpux
Copy link

Alexpux commented Feb 27, 2024

Hi, Im maintainer of MSYS2 project that provide toolchains and many prebuilded open source libraries for Windows users using package manager. So I'm use MSYS2 installation that already have boost library builded.
I'm fix issue with pthread by reinterpret_cast<pthread_t> for native_handle.

@Alexpux
Copy link

Alexpux commented Feb 27, 2024

@Iandiehard also Windows MSVC compilers don't have PThreads API. Windows use its own threads model. Pthread API is not standart for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants