Merge pull request #1 from Ibotta/args-normalization-2

build fixes

Author: onyxraven

.editorconfig

@@ -0,0 +1,16 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+indent_style = space
+indent_size = 2
+
+[*.{diff}]
+trim_trailing_whitespace = false

.github/workflows/ci.yml

@@ -0,0 +1,43 @@
+on:
+  push:
+    branches: [$default-branch]
+  pull_request:
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    services:
+      # Label used to access the service container
+      redis:
+        # Docker Hub image
+        image: redis
+        # Set health checks to wait until redis has started
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          # Maps port 6379 on service container to the host
+          - '6379:6379'
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version: ['2.7', '3.0', '3.1', '3.2']
+        gemfile: ['Gemfile', 'Gemfile.redis3', 'Gemfile.redis4']
+    env:
+      # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }}
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run tests
+        env:
+          # The hostname used to communicate with the Redis service container
+          REDIS_TEST_HOST: localhost
+          # The default Redis port
+          REDIS_TEST_PORT: 6379
+        run: bundle exec rake

.gitignore

@@ -5,3 +5,5 @@ Gemfile.lock
 coverage/
 .rbx/
 .bundle/
+dump.rdb
+stdout

.travis.yml

@@ -0,0 +1,74 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+education, socio-economic status, nationality, personal appearance, race,
+religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at [email protected]. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+

CODE_OF_CONDUCT.md

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+gemspec
+
+gem 'redis', '~> 3.3'
+gem 'redis-namespace', '~> 1.5.3'

Gemfile.redis3

@@ -0,0 +1,5 @@
+source 'https://rubygems.org'
+gemspec
+
+gem 'redis', '~> 4.8'
+gem 'redis-namespace', '~> 1.9'

Gemfile.redis4

@@ -1,3 +1,11 @@
+## 0.5.0 (Ibotta) (2023-01-23)
+
+- Fix: normalize args when creating identifier
+- Fix: adjust test with concurrency issues
+- Maintenance: Update gem dependencies to support rubies >= 2.7
+- Maintenance: test against redis gem 3, 4
+- Maintenance: run in github actions
+
 ## 0.4.5 (2015-08-04)
 
 - Fix: ensure exceptions are kept if raised **after** lock timeout expires.

HISTORY.md

@@ -1,3 +1,4 @@
+Copyright (c) 2023 Ibotta
 Copyright (c) 2010 Chris Wanstrath
 Copyright (c) 2010 Ryan Carver
 Copyright (c) 2010 Luke Antins